fixed the bug in the permutation #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreBelling
approved these changes
Oct 10, 2024
Soleimani193
force-pushed
the
prover/compiler-issue-for-permutation
branch
from
b714e11
to
84134b3
Compare
gusiri
approved these changes
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=========================================
Coverage 70.38% 70.38%
Complexity 1040 1040
=========================================
Files 282 282
Lines 11314 11314
Branches 1082 1082
=========================================
Hits 7963 7963
Misses 2880 2880
Partials 471 471
|
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the permutation-query.
for the multi-column cases, the Z polynomial nominator and dominator were both built based on the same polynomial A (rather than A against B). Causing the verifier to accept false claims over multi-column cases.
More test cases are added to cover the false claims that we don't expect the verifier to accept.
Checklist